Fix #100: Add purge support #104
Conversation
hdpoliveira
force-pushed
the
issue_100
branch
2 times, most recently
from
cd8e78e to
58fc04a
Compare
| @@ -23,6 +23,9 @@ | |||
| "command.update": "Update to...", | |||
| "command.branch": "Create Branch...", | |||
| "command.pull": "Pull", | |||
| "command.purge": "Purge", | |||
| "command.purgeFiles": "Purge All Untracked Files", | |||
There was a problem hiding this comment.
What is the difference between "Purge" and "Purge All Untracked Files"?
There was a problem hiding this comment.
Purge is for the individual file, and Purge all untracked is for the whole untracked files source group.
This allow the user to have a fine grain control on the Untracked Source Group view.
package.json
Outdated
| "command": "hg.purgeFiles", | ||
| "title": "%command.purgeFiles%", | ||
| "category": "Hg", | ||
| "icon": "$(discard)" |
There was a problem hiding this comment.
purge is very different from discarding changes. If I saw this in the hg extension, I would assume it discards changes, and would be frustrated if it deleted my untracked files. This should not use the discard icon, because that icon implies reverting changes rather than deleting files. I don't think this command is used frequently enough to warrant a top-level icon in the SCM pane. It should just be a command in the command palette.
There was a problem hiding this comment.
The git extension uses the discard icon for untracked files, and it is really useful to be able to purge the files from the SCM view.
The tool also asks the user for confirmation, informing this is irreversible.
Also, the user has to enable purge extension for this to work, so they know what they are doing here.
There was a problem hiding this comment.
I guess the git extension uses the discard icon because it doesn't have a separate group for Untracked files, so it has to be consistent with the other files.
In our case we should use the trash icon instead. I believe this will be informing enough to the user that this action deletes files.
Icon reference: https://code.visualstudio.com/api/references/icons-in-labels
|
|
||
| @command('hg.purge') | ||
| async purge(...resourceStates: SourceControlResourceState[]): Promise<void> { | ||
| if (resourceStates.length === 0) { |
There was a problem hiding this comment.
Why should there be an option to purge specific files? Selecting specific files to send to the purge command is the same thing as selecting specific files and then deleting them.
There was a problem hiding this comment.
Yes, you're right. Currently there is no way of deleting untracked files from the SCM tab, so this is what I am implementing.
|
|
|
Thanks for the demo. Looks great. |
|
Thanks for making these changes. I saw after I made the notes that the git extension does indeed use the discard icon. This is better, though. :) |
|
Yeah, it does look better with the trash icon, and I wouldn't have found it without your review! Thanks! |
The code does not check if the extension is enabled.
Instead it shows an error when tried to run the command and the extension is missing.